Preserve file extension when downloading

Fixes #195

.github/workflows/check-dist.yml

@@ -36,7 +36,7 @@ jobs:
 
       - name: Setup Node.js
         id: setup-node
-        uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
+        uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
         with:
           node-version-file: .node-version
           cache: npm
@@ -70,7 +70,7 @@ jobs:
       - if: ${{ failure() && steps.diff.outcome == 'failure' }}
         name: Upload Artifact
         id: upload
-        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
+        uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
         with:
           name: dist
           path: dist/

.github/workflows/ci.yml

@@ -20,7 +20,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - name: Setup Node.js
-        uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
+        uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
         with:
           node-version-file: .node-version
           cache: npm

eslint.config.mjs

@@ -9,13 +9,9 @@ import _import from 'eslint-plugin-import'
 import jest from 'eslint-plugin-jest'
 import prettier from 'eslint-plugin-prettier'
 import globals from 'globals'
-import path from 'node:path'
-import { fileURLToPath } from 'node:url'
 
-const __filename = fileURLToPath(import.meta.url)
-const __dirname = path.dirname(__filename)
 const compat = new FlatCompat({
-  baseDirectory: __dirname,
+  baseDirectory: import.meta.dirname,
   recommendedConfig: js.configs.recommended,
   allConfig: js.configs.all
 })
@@ -52,8 +48,18 @@ export default [
       sourceType: 'module',
 
       parserOptions: {
-        project: ['tsconfig.eslint.json'],
+        projectService: {
-        tsconfigRootDir: __dirname
+          allowDefaultProject: [
+            '__fixtures__/*.ts',
+            '__tests__/*.ts',
+            'eslint.config.mjs',
+            'jest.config.js',
+            'rollup.cleanup.config.ts',
+            'rollup.main.config.ts'
+          ],
+          maximumDefaultProjectFileMatchCount_THIS_WILL_SLOW_DOWN_LINTING: 32
+        },
+        tsconfigRootDir: import.meta.dirname
       }
     },
 
@@ -61,7 +67,7 @@ export default [
       'import/resolver': {
         typescript: {
           alwaysTryTypes: true,
-          project: 'tsconfig.eslint.json'
+          project: 'tsconfig.json'
         }
       }
     },

jest.config.js

@@ -20,7 +20,7 @@ export default {
     '^.+\\.ts$': [
       'ts-jest',
       {
-        tsconfig: 'tsconfig.eslint.json',
+        tsconfig: 'tsconfig.json',
         useESM: true
       }
     ]

package.json

@@ -42,39 +42,39 @@
     "@actions/exec": "^1.1.1",
     "@actions/github": "^6.0.1",
     "@actions/glob": "^0.5.0",
-    "@actions/http-client": "^2.2.3",
+    "@actions/http-client": "^3.0.0",
-    "@actions/io": "^1.1.3",
+    "@actions/io": "^2.0.0",
     "@actions/tool-cache": "^2.0.2",
-    "@octokit/types": "^15.0.0",
+    "@octokit/types": "^16.0.0",
     "@github/dependency-submission-toolkit": "^2.0.5",
-    "semver": "^7.7.2",
+    "semver": "^7.7.3",
     "uuid": "^13.0.0"
   },
   "devDependencies": {
-    "@eslint/compat": "^1.4.0",
+    "@eslint/compat": "^1.4.1",
-    "@rollup/plugin-commonjs": "^28.0.6",
+    "@rollup/plugin-commonjs": "^29.0.0",
     "@rollup/plugin-json": "^6.1.0",
-    "@rollup/plugin-node-resolve": "^16.0.1",
+    "@rollup/plugin-node-resolve": "^16.0.3",
-    "@rollup/plugin-typescript": "^12.1.4",
+    "@rollup/plugin-typescript": "^12.3.0",
     "@types/jest": "^30.0.0",
-    "@types/node": "^24.6.1",
+    "@types/node": "^24.9.2",
     "@types/semver": "^7.7.1",
-    "@typescript-eslint/eslint-plugin": "^8.45.0",
+    "@typescript-eslint/eslint-plugin": "^8.46.2",
     "@typescript-eslint/parser": "^8.31.1",
-    "eslint": "^9.36.0",
+    "eslint": "^9.39.0",
     "eslint-config-prettier": "^10.1.8",
     "eslint-import-resolver-typescript": "^4.4.4",
     "eslint-plugin-import": "^2.32.0",
     "eslint-plugin-jest": "^29.0.1",
-    "eslint-plugin-jsonc": "^2.20.1",
+    "eslint-plugin-jsonc": "^2.21.0",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-prettier": "^5.5.4",
     "jest": "^30.2.0",
     "js-yaml": "^4.1.0",
     "prettier": "^3.6.2",
     "prettier-eslint": "^16.4.2",
-    "rollup": "^4.52.3",
+    "rollup": "^4.52.5",
-    "ts-jest": "^29.4.4",
+    "ts-jest": "^29.4.5",
     "ts-jest-resolver": "^2.0.1",
     "ts-node": "^10.9.2",
     "typescript": "^5.9.3"

src/features/musl.ts

@@ -2,6 +2,7 @@ import * as c from '../constants.js'
 import * as core from '@actions/core'
 import * as tc from '@actions/tool-cache'
 import { join } from 'path'
+import { downloadFile } from '../utils.js'
 
 const MUSL_NAME = 'musl-toolchain'
 const MUSL_VERSION = '1.2.5-oracle-00001'
@@ -16,7 +17,7 @@ export async function setUpNativeImageMusl(): Promise<void> {
     core.info(`Found ${MUSL_NAME} ${MUSL_VERSION} in tool-cache @ ${toolPath}`)
   } else {
     core.startGroup(`Setting up musl for GraalVM Native Image...`)
-    const muslDownloadPath = await tc.downloadTool(
+    const muslDownloadPath = await downloadFile(
       `https://gds.oracle.com/download/bfs/archive/musl-toolchain-${MUSL_VERSION}-linux-amd64.tar.gz`
     )
     const muslExtractPath = await tc.extractTar(muslDownloadPath)

src/graalvm.ts

@@ -2,6 +2,7 @@ import * as c from './constants.js'
 import * as core from '@actions/core'
 import * as semver from 'semver'
 import {
+  downloadFile,
   downloadAndExtractJDK,
   downloadExtractAndCacheJDK,
   getContents,
@@ -10,7 +11,6 @@ import {
   getTaggedRelease
 } from './utils.js'
 import { downloadGraalVM, downloadGraalVMEELegacy } from './gds.js'
-import { downloadTool } from '@actions/tool-cache'
 import { basename } from 'path'
 
 const GRAALVM_DL_BASE = 'https://download.oracle.com/graalvm'
@@ -153,7 +153,7 @@ function determineToolName(javaVersion: string, isCommunity: boolean) {
 
 async function downloadGraalVMJDK(downloadUrl: string, javaVersion: string): Promise<string> {
   try {
-    return await downloadTool(downloadUrl)
+    return await downloadFile(downloadUrl)
   } catch (error) {
     if (error instanceof Error && error.message.includes('404')) {
       // Not Found
@@ -260,7 +260,7 @@ async function downloadGraalVMCELegacy(version: string, javaVersion: string): Pr
   const graalVMIdentifier = determineGraalVMLegacyIdentifier(false, version, javaVersion)
   const downloadUrl = `${GRAALVM_CE_DL_BASE}/${GRAALVM_TAG_PREFIX}${version}/${graalVMIdentifier}${c.GRAALVM_FILE_EXTENSION}`
   try {
-    return await downloadTool(downloadUrl)
+    return await downloadFile(downloadUrl)
   } catch (error) {
     if (error instanceof Error && error.message.includes('404')) {
       // Not Found

src/liberica.ts

@@ -1,7 +1,6 @@
 import * as c from './constants.js'
 import * as semver from 'semver'
-import { downloadExtractAndCacheJDK, getTaggedRelease, getMatchingTags } from './utils.js'
+import { downloadFile, downloadExtractAndCacheJDK, getTaggedRelease, getMatchingTags } from './utils.js'
-import { downloadTool } from '@actions/tool-cache'
 import { spawnSync } from 'child_process'
 
 const LIBERICA_GH_USER = 'bell-sw'
@@ -13,7 +12,7 @@ export async function setUpLiberica(javaVersion: string, javaPackage: string): P
   const resolvedJavaVersion = await findLatestLibericaJavaVersion(javaVersion)
   const downloadUrl = await findLibericaURL(resolvedJavaVersion, javaPackage)
   const toolName = determineToolName(javaVersion, javaPackage)
-  return downloadExtractAndCacheJDK(async () => downloadTool(downloadUrl), toolName, javaVersion)
+  return downloadExtractAndCacheJDK(async () => downloadFile(downloadUrl), toolName, javaVersion)
 }
 
 export async function findLatestLibericaJavaVersion(javaVersion: string): Promise<string> {

src/utils.ts

@@ -5,9 +5,10 @@ import * as semver from 'semver'
 import * as tc from '@actions/tool-cache'
 import * as fs from 'fs'
 import { ExecOptions, exec as e } from '@actions/exec'
+import { ok } from 'assert'
 import { readFileSync, readdirSync } from 'fs'
 import { createHash } from 'crypto'
-import { join } from 'path'
+import { extname, join } from 'path'
 import { tmpdir } from 'os'
 import { GitHub } from '@actions/github/lib/utils.js'
 
@@ -86,6 +87,17 @@ export async function downloadExtractAndCacheJDK(
   return findJavaHomeInSubfolder(toolPath)
 }
 
+export async function downloadFile(downloadUrl: string): Promise<string> {
+  const dest = join(_getTempDirectory(), crypto.randomUUID(), extname(downloadUrl))
+  return tc.downloadTool(downloadUrl, dest)
+}
+
+function _getTempDirectory(): string {
+  const tempDirectory = process.env['RUNNER_TEMP'] || ''
+  ok(tempDirectory, 'Expected RUNNER_TEMP to be defined')
+  return tempDirectory
+}
+
 export function calculateSHA256(filePath: string): string {
   const hashSum = createHash('sha256')
   hashSum.update(readFileSync(filePath))

tsconfig.base.json

@@ -1,23 +0,0 @@
-{
-  "$schema": "https://json.schemastore.org/tsconfig",
-  "compilerOptions": {
-    "allowSyntheticDefaultImports": true,
-    "declaration": false,
-    "declarationMap": false,
-    "esModuleInterop": true,
-    "forceConsistentCasingInFileNames": true,
-    "lib": ["ES2022"],
-    "module": "NodeNext",
-    "moduleResolution": "NodeNext",
-    "newLine": "lf",
-    "noImplicitAny": true,
-    "noUnusedLocals": true,
-    "noUnusedParameters": false,
-    "pretty": true,
-    "resolveJsonModule": true,
-    "sourceMap": false,
-    "strict": true,
-    "strictNullChecks": true,
-    "target": "ES2022"
-  }
-}

tsconfig.eslint.json

@@ -1,18 +0,0 @@
-{
-  "$schema": "https://json.schemastore.org/tsconfig",
-  "extends": "./tsconfig.base.json",
-  "compilerOptions": {
-    "allowJs": true,
-    "noEmit": true
-  },
-  "exclude": ["dist", "node_modules"],
-  "include": [
-    "__fixtures__",
-    "__tests__",
-    "src",
-    "eslint.config.mjs",
-    "jest.config.js",
-    "rollup.cleanup.config.ts",
-    "rollup.main.config.ts"
-  ]
-}

tsconfig.json

@@ -1,11 +1,25 @@
 {
   "$schema": "https://json.schemastore.org/tsconfig",
-  "extends": "./tsconfig.base.json",
   "compilerOptions": {
+    "allowSyntheticDefaultImports": true,
+    "declaration": false,
+    "declarationMap": false,
+    "esModuleInterop": true,
+    "forceConsistentCasingInFileNames": true,
     "isolatedModules": true,
+    "lib": ["ES2022"],
     "module": "NodeNext",
     "moduleResolution": "NodeNext",
-    "outDir": "./dist"
+    "newLine": "lf",
+    "noImplicitAny": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": false,
+    "outDir": "./dist",
+    "pretty": true,
+    "resolveJsonModule": true,
+    "strict": true,
+    "strictNullChecks": true,
+    "target": "ES2022"
   },
   "exclude": ["__fixtures__", "__tests__", "coverage", "dist", "node_modules"],
   "include": ["src"]